fix: replace bunyan logger #1447
Conversation
abhilash-sivan
force-pushed
the
fix-replace-bunyan
branch
from
a34cab4 to
5e5f845
Compare
abhilash-sivan
force-pushed
the
fix-replace-bunyan
branch
from
c756449 to
accb4aa
Compare
| @@ -267,9 +267,11 @@ exports.sendSpans = function sendSpans(spans, cb) { | |||
| if (err && !maxContentErrorHasBeenLogged && err instanceof PayloadTooLargeError) { | |||
| logLargeSpans(spans); | |||
| } else if (err) { | |||
| logger.debug('Failed to send: %s', getSpanLengthInfo(spans)); | |||
| const obj = getSpanLengthInfo(spans); | |||
There was a problem hiding this comment.
Pino does not support concatenated strings using %s if an object is passed instead of a string.
| * Custom write method to send logs to multiple destinations | ||
| * @param {string} chunk | ||
| */ | ||
| write(chunk) { |
There was a problem hiding this comment.
custom write method which writes the log to stdout and agent stream function (pinoToAgentStream)
There was a problem hiding this comment.
I tried implementing this use case using pino.transport, pino.destination and pino.multistream etc. And finally ended up with the current implementation which is working as expected like previous bunyan stream
| @@ -31,40 +31,57 @@ const registry = {}; | |||
| * @param {boolean} [isReInit] | |||
| */ | |||
| exports.init = function init(config, isReInit) { | |||
| const consoleStream = pino.destination(1); | |||
There was a problem hiding this comment.
If multistream is used, we need to specify the log streams where it is going. Here this is defined for logging into the process.stdout
| parentLogger = pino( | ||
| { | ||
| ...parentLogger.levels, | ||
| base: parentLogger.bindings() |
There was a problem hiding this comment.
if we want to change something in pino logger after it is initialized, we need to create a new logger and assign initial logger bindings to it
%sand correct it