Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop R process if AppDriver fails in test-examples #820

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

averissimo
Copy link
Contributor

Pull Request

Fixes insightsengineering/teal.modules.clinical#1302 on teal.modules.general

@averissimo averissimo changed the title feat: stop R process after AppDriver fails Stop R process after AppDriver fails in test-examples Dec 16, 2024
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------
R/tm_a_pca.R                    884     884  0.00%    138-1155
R/tm_a_regression.R             772     772  0.00%    162-1036
R/tm_data_table.R               215     215  0.00%    110-380
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               133     122  8.27%    73-231
R/tm_g_association.R            340     340  0.00%    143-556
R/tm_g_bivariate.R              685     421  38.54%   315-794, 835, 946, 963, 981, 992-1014
R/tm_g_distribution.R          1110    1110  0.00%    155-1411
R/tm_g_response.R               364     364  0.00%    161-601
R/tm_g_scatterplot.R            736     736  0.00%    244-1085
R/tm_g_scatterplotmatrix.R      296     277  6.42%    182-516, 577, 591
R/tm_missing_data.R            1111    1111  0.00%    122-1408
R/tm_outliers.R                1031    1031  0.00%    162-1342
R/tm_t_crosstable.R             261     261  0.00%    148-459
R/tm_variable_browser.R         830     825  0.60%    89-1081, 1119-1303
R/utils.R                       156     125  19.87%   81-266, 296-327, 348, 351, 356, 371-392, 403, 408
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9099    8769  3.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 926d4d0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Unit Tests Summary

  1 files   22 suites   13m 22s ⏱️
145 tests 108 ✅ 37 💤 0 ❌
477 runs  439 ✅ 38 💤 0 ❌

Results for commit 926d4d0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💚 $119.99$ $-1.97$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 💔 $59.36$ $+1.28$ $0$ $0$ $0$ $0$
shinytest2-tm_g_response 💔 $28.85$ $+1.39$ $0$ $0$ $0$ $0$
shinytest2-tm_misssing_data 💔 $47.16$ $+2.28$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $108.73$ $+3.44$ $0$ $0$ $0$ $0$
shinytest2-tm_t_crosstable 💔 $31.50$ $+1.04$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💔 $58.47$ $+1.96$ $0$ $0$ $0$ $0$

Results for commit 32e473a

♻️ This comment has been updated with latest results.

@averissimo averissimo changed the title Stop R process after AppDriver fails in test-examples Stop R process if AppDriver fails in test-examples Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App driver R process is not stopped during fails of test-examples.R
1 participant