Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change maxLenght of username to 64 at login #4196

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

mateo-ivc
Copy link
Collaborator

Description

When creating a user the max length of the username is set to 20 characters even though we allow a max length of 64 when changing the name.

Changelog

src/routes/LoginBoard/LoginBoard.tsx
Changed maxLength attribute from 20 to 64

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@mateo-ivc mateo-ivc self-assigned this Jun 4, 2024
@mateo-ivc mateo-ivc added the Review Needed This pull request is ready for review label Jun 4, 2024
Copy link

octomind-dev bot commented Jun 4, 2024

🐙 Octomind

Test Report: 12/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Failed ❌ click

commit sha: f3d32dc

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4196.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-3bec1bd

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-3bec1bd

Copy link

octomind-dev bot commented Jun 10, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 3bec1bd

@mateo-ivc mateo-ivc added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 2c31e2b Jun 10, 2024
6 checks passed
@mateo-ivc mateo-ivc deleted the mi/changen-max-length-of-username-at-creation branch June 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants