Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass default_action (if HTTP_SOAPACTION undefined) #117

Closed
wants to merge 1 commit into from

Conversation

maxd
Copy link

@maxd maxd commented Sep 23, 2013

Hello,

I have read #24 and implemented idea described in comment.

I can't pass HTTP_SOAPACTION because I am not owner of code. So, need to have solution to prevent this problem on my side.

Thanks

P.S.
Workaround with Rack middleware looks like guerrilla patch and I don' want to use it in my project.

@inossidabile
Copy link
Owner

How do you get a request without HTTP_SOAPACTION? It violates SOAP format. Why do you expect WashOut to support and respond such request?

@maxd
Copy link
Author

maxd commented Sep 24, 2013

Qiwi Wallet (Russian payment system) send it. I don't think that they will change it for me, so required solution on my side.

Are you absolutely sure that HTTP_SOAPACTION is only one way to determine called action?

@inossidabile
Copy link
Owner

Can you provide a dump of such request? Since it's a public system, you shouldn't be blocked by any agreements.

We'll do whatever it takes to help you since who cares about standards when they not work? I mean WashOut should be usable and not "strict-compliant". I just want to be sure we make a proper workaround if we go against spec.

@maxd
Copy link
Author

maxd commented Sep 24, 2013

Yes, sure. I will try to dump requests evening.

@inossidabile
Copy link
Owner

👍 💃

@maxd
Copy link
Author

maxd commented Sep 24, 2013

I have dumped SOAP request.

screen shot 2013-09-24 at 10 31 51 pm

As you can see SOAPAction header is empty. Also I have found the following post about situation with this header: http://michelchristianen.blogspot.ru/2011/02/understanding-soapaction-mystery_5785.html

So, SOAPAction header using for optimize processing of requests in proxies or firewalls. Therefore need to use SOAP method name from Envelope body. Can you implement this?

I close my pull-request.

@maxd maxd closed this Sep 24, 2013
@inossidabile inossidabile reopened this Sep 24, 2013
@inossidabile
Copy link
Owner

I'll keep it open unless everything that solves this is implemented. And yes, I'll take my hands on it, thank you.

@inossidabile
Copy link
Owner

0.9.0.beta-2 released. Please try.

@mhenrixon
Copy link
Contributor

Thanks this solves an issue I was running into right now.

@inossidabile
Copy link
Owner

@mhenrixon awesome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants