Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer dependencies and toolchain #128

Merged

Conversation

cmichi
Copy link
Contributor

@cmichi cmichi commented Nov 28, 2024

@pmikolajczyk41 or @deuszx Would it be possible to merge this today and publish a new release? That would be great!

deuszx
deuszx previously approved these changes Nov 28, 2024
Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly straightforward to me. Let's wait for @pmikolajczyk41 for final review.

EDIT
Sorry, didn't notice CI is not passing. Let's make sure everything's green first.

@deuszx deuszx dismissed their stale review November 28, 2024 10:39

Didn't notice CI is red.

@cmichi
Copy link
Contributor Author

cmichi commented Nov 28, 2024

@deuszx Argh, I had run clippy locally, but apparently with different flags. I'll fix it.

@deuszx
Copy link
Collaborator

deuszx commented Nov 28, 2024

@cmichi One more thing – I know that CHANGELOG.md became a bit outdated but I think this particular release is more important than other so please add the entry there.

@cmichi
Copy link
Contributor Author

cmichi commented Nov 28, 2024

@deuszx Done! Could you re-approve the CI run?

@pmikolajczyk41 pmikolajczyk41 merged commit 94835ac into inkdevhub:main Nov 28, 2024
2 checks passed
@cmichi cmichi deleted the cmichi-upgrade-to-cargo-contract-5.0-deps branch November 28, 2024 12:02
@pmikolajczyk41
Copy link
Member

@cmichi new version has been just published

@cmichi
Copy link
Contributor Author

cmichi commented Nov 28, 2024

@pmikolajczyk41 @deuszx Great! And thanks for the super quick handling of this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants