Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): Invert event processing #405

Merged
merged 13 commits into from
Feb 27, 2022
Merged

refactor(parser): Invert event processing #405

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8daef5a
refactor(parser): Introduce token callbacks
fb55 Jan 27, 2022
3887ac4
Use tokenizer `allowCDATA` to determine foreign content of text
fb55 Jan 27, 2022
b0e60bd
Fix `tokenInHead`, revert some changes
fb55 Jan 27, 2022
b0a1d79
Fix self closing being reported multiple times for some start tags
fb55 Jan 27, 2022
b0f08ed
Shorten callback names
fb55 Jan 27, 2022
6d6a9b6
Simplify `shouldProcessStartTagTokenInForeignContent`
fb55 Jan 27, 2022
95b9fe4
Pass primitive values to some fns
fb55 Jan 29, 2022
cc63410
Revert "Pass primitive values to some fns"
fb55 Feb 11, 2022
be7394d
Fix `generate-parser-feedback-test`
fb55 Feb 11, 2022
7099e8d
Don't set `skipNextNewLine = false` on EOF
fb55 Feb 11, 2022
4bd7d88
Rename `_considerForeignContent` and `allowCDATA`
fb55 Feb 11, 2022
8156155
Add link to multi-page HTML spec
fb55 Feb 11, 2022
542a142
Merge remote-tracking branch 'upstream/master' into refactor/cbs
fb55 Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/parse5-sax-parser/lib/parser-feedback-simulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ export class ParserFeedbackSimulator {
private _enterNamespace(namespace: NS): void {
this.namespaceStack.unshift(namespace);
this.inForeignContent = namespace !== NS.HTML;
this.tokenizer.allowCDATA = this.inForeignContent;
this.tokenizer.inForeignNode = this.inForeignContent;
}

private _leaveCurrentNamespace(): void {
this.namespaceStack.shift();
this.inForeignContent = this.namespaceStack[0] !== NS.HTML;
this.tokenizer.allowCDATA = this.inForeignContent;
this.tokenizer.inForeignNode = this.inForeignContent;
}

//Token handlers
Expand Down
Loading