Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): Add hooks for stack events #385

Merged
merged 4 commits into from
Feb 12, 2022

Conversation

fb55
Copy link
Collaborator

@fb55 fb55 commented Jan 18, 2022

JSDOM currently monkey-patches parse5 to get these events. With this change, that is no longer necessary.

Fixes #237, #285.

@fb55 fb55 force-pushed the feat/stack-events branch from bc0a1f7 to cc0d661 Compare February 7, 2022 14:17
@fb55 fb55 marked this pull request as ready for review February 7, 2022 14:29
Copy link
Collaborator

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reference where this was requested? The reason this is added?

packages/parse5/lib/parser/index.test.ts Show resolved Hide resolved
@fb55
Copy link
Collaborator Author

fb55 commented Feb 10, 2022

Can you reference where this was requested? The reason this is added?

Ahh, good catch. This was requested in #237, plus again in #285.

@fb55 fb55 merged commit 68d4438 into inikulin:master Feb 12, 2022
@fb55 fb55 deleted the feat/stack-events branch February 12, 2022 18:23
fb55 added a commit to parse5/parse5-fork that referenced this pull request Mar 2, 2022
jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need more insight into the stack of open elements
2 participants