Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Decouple output directory from call to save #10

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

andrewgryan
Copy link

De-couple hard coded directory locations to make it easier to separate concerns between script invocations.

@andrewgryan
Copy link
Author

Now that I've gotten goofys to mount the S3 bucket the intention is to modify the code/cli to be flexible enough to accept a few high-level directory locations, so that --output-dir and --mount-dir or something suitably abstract can be supported

@andrewgryan
Copy link
Author

This PR could pivot to be a migrate step to R package instead of only a decoupling from the file system

@andrewgryan
Copy link
Author

andrewgryan commented Feb 14, 2023

@DPeterK this is a transitionary fossil, the main idea is to extract functions but is a perhaps better as a migration task now that we have a DIMEX package, it could be data_prep_* step(s)

@DPeterK
Copy link

DPeterK commented Feb 14, 2023

Yes if the aim is to move all (?) IO into the API / server then the ideas here are probably better (eventually) migrated out of the DIMEX codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants