Fix #241 evidence JSON format #242
Merged
+143
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
approved these changes
Apr 29, 2020
|
Integration tests fail because of #233. Unrelated to this PR and can be ignored. |
liamsi
reviewed
Apr 29, 2020
| pub enum Evidence { | ||
| /// Duplicate vote evidence | ||
| #[serde(rename = "tendermint/DuplicateVoteEvidence")] | ||
| DuplicateVote(DuplicateVoteEvidence), |
liamsi
approved these changes
Apr 29, 2020
liamsi
reviewed
Apr 29, 2020
| /// Duplicate vote evidence | ||
| #[derive(Serialize, Deserialize, Clone, Debug)] | ||
| pub struct DuplicateVoteEvidence { | ||
| #[serde(rename = "PubKey")] |
There was a problem hiding this comment.
I'm surprised to see that the JSON produces CamelCase instead of snake_case for these fields.
There was a problem hiding this comment.
Opened an issue to track it tendermint/tendermint#4958 !
There was a problem hiding this comment.
Thanks! I didn’t know that this would count as a bug. Thought it’s just a minor inconsistency.
liamsi
reviewed
Jun 4, 2020
| #[derive(Serialize, Deserialize, Clone, Debug)] | ||
| pub struct DuplicateVoteEvidence { | ||
| #[serde(rename = "PubKey")] | ||
| pub_key: PublicKey, |
There was a problem hiding this comment.
I just noted that in the go versions there is no pubkey field (anymore?). We need to remove this for compatibility. Tracking here: #300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
newandto_amino_bytesmethods.