Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Fix CI badges, update minimum Rust version, update logo in docs #234

Merged
merged 2 commits into from
Apr 22, 2020
Merged

README: Fix CI badges, update minimum Rust version, update logo in docs #234

merged 2 commits into from
Apr 22, 2020

Conversation

romac
Copy link
Member

@romac romac commented Apr 22, 2020

Closes: #223

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@romac romac requested a review from liamsi April 22, 2020 13:34
@informalsystems informalsystems deleted a comment from codecov-io Apr 22, 2020
@romac romac force-pushed the romac/fix-readme branch from e0f46f7 to 109b1fd Compare April 22, 2020 16:22
@romac
Copy link
Member Author

romac commented Apr 22, 2020

@liamsi Just addressed your comments.

liamsi
liamsi approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👍

@liamsi liamsi merged commit 26d81be into master Apr 22, 2020
@liamsi liamsi deleted the romac/fix-readme branch April 22, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove circleci badge from readme & update logo
2 participants
@romac @liamsi