Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-client refactor: Re-export new verifier crate from tendermint-light-client #1074

Merged
merged 4 commits into from
Jan 12, 2022

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Jan 12, 2022

Some suggestions for #1071.

This PR re-exports the tendermint-light-client-verifier crate from tendermint-light-client to allow users of the tendermint-light-client crate easy access to the verifier.

It also adds some minor documentation updates and a changelog entry.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@thanethomson thanethomson marked this pull request as ready for review January 12, 2022 01:41
@codecov-commenter
Copy link

Codecov Report

Merging #1074 (d891875) into soares/light-client-verifier (b0e1372) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##           soares/light-client-verifier   #1074     +/-   ##
==============================================================
- Coverage                          64.2%   64.2%   -0.1%     
==============================================================
  Files                               238     238             
  Lines                             20705   20705             
==============================================================
- Hits                              13303   13301      -2     
- Misses                             7402    7404      +2     
Impacted Files Coverage Δ
light-client-js/src/lib.rs 3.7% <ø> (ø)
light-client-js/tests/web.rs 100.0% <ø> (ø)
light-client-verifier/src/lib.rs 100.0% <ø> (ø)
light-client/examples/light_client.rs 0.0% <ø> (ø)
light-client/src/builder/error.rs 0.0% <ø> (ø)
light-client/src/builder/light_client.rs 0.0% <ø> (ø)
light-client/src/builder/supervisor.rs 0.0% <ø> (ø)
light-client/src/components/clock.rs 0.0% <ø> (ø)
light-client/src/components/io.rs 28.8% <ø> (ø)
light-client/src/components/scheduler.rs 87.0% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e1372...d891875. Read the comment docs.

@soareschen soareschen merged commit f062e5f into soares/light-client-verifier Jan 12, 2022
@soareschen soareschen deleted the thane/light-client-verifier branch January 12, 2022 09:16
soareschen pushed a commit that referenced this pull request Jan 12, 2022
…light-client` (#1074)

* Re-export tendermint_light_client_verifier as verifier from tendermint_light_client

Signed-off-by: Thane Thomson <[email protected]>

* Remove unnecessary tendermint-light-client import

Signed-off-by: Thane Thomson <[email protected]>

* Fix crate docs to reflect verifier extraction

Signed-off-by: Thane Thomson <[email protected]>

* Add changelog entry

Signed-off-by: Thane Thomson <[email protected]>
thanethomson added a commit that referenced this pull request Jan 12, 2022
…light-client-verifier` (#1071)

* Split out verifier parts of tendermint-light-client to tendermint-light-client-verifier

* Add Time::now() method behind clock feature

* light-client refactor: Re-export new verifier crate from `tendermint-light-client` (#1074)

* Re-export tendermint_light_client_verifier as verifier from tendermint_light_client

Signed-off-by: Thane Thomson <[email protected]>

* Remove unnecessary tendermint-light-client import

Signed-off-by: Thane Thomson <[email protected]>

* Fix crate docs to reflect verifier extraction

Signed-off-by: Thane Thomson <[email protected]>

* Add changelog entry

Signed-off-by: Thane Thomson <[email protected]>

* Re-export the original exports in light-client crate

Co-authored-by: Thane Thomson <[email protected]>
thanethomson added a commit that referenced this pull request Jan 12, 2022
…ht-client-verifier (Backported to v0.23) (#1072)

* Split out verifier parts of tendermint-light-client to tendermint-light-client-verifier

Rebased from master

* Re-apply v0.23-specific changes

* Missed patch in kvstore-test

* Fix light-client-js test

* Add Time::now() method behind clock feature

* light-client refactor: Re-export new verifier crate from `tendermint-light-client` (#1074)

* Re-export tendermint_light_client_verifier as verifier from tendermint_light_client

Signed-off-by: Thane Thomson <[email protected]>

* Remove unnecessary tendermint-light-client import

Signed-off-by: Thane Thomson <[email protected]>

* Fix crate docs to reflect verifier extraction

Signed-off-by: Thane Thomson <[email protected]>

* Add changelog entry

Signed-off-by: Thane Thomson <[email protected]>

* Re-export the original exports in light-client crate

* light-client refactor: Merge latest changes from v0.23.x (#1075)

* Merge latest changes from v0.23.x

Signed-off-by: Thane Thomson <[email protected]>

* Remove redundant imports from kvstore test

Signed-off-by: Thane Thomson <[email protected]>

Co-authored-by: Thane Thomson <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants