-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
light-client refactor: Re-export new verifier crate from tendermint-light-client
#1074
Merged
soareschen
merged 4 commits into
soares/light-client-verifier
from
thane/light-client-verifier
Jan 12, 2022
Merged
light-client refactor: Re-export new verifier crate from tendermint-light-client
#1074
soareschen
merged 4 commits into
soares/light-client-verifier
from
thane/light-client-verifier
Jan 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_light_client Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## soares/light-client-verifier #1074 +/- ##
==============================================================
- Coverage 64.2% 64.2% -0.1%
==============================================================
Files 238 238
Lines 20705 20705
==============================================================
- Hits 13303 13301 -2
- Misses 7402 7404 +2
Continue to review full report at Codecov.
|
soareschen
approved these changes
Jan 12, 2022
soareschen
pushed a commit
that referenced
this pull request
Jan 12, 2022
…light-client` (#1074) * Re-export tendermint_light_client_verifier as verifier from tendermint_light_client Signed-off-by: Thane Thomson <[email protected]> * Remove unnecessary tendermint-light-client import Signed-off-by: Thane Thomson <[email protected]> * Fix crate docs to reflect verifier extraction Signed-off-by: Thane Thomson <[email protected]> * Add changelog entry Signed-off-by: Thane Thomson <[email protected]>
Merged
5 tasks
thanethomson
added a commit
that referenced
this pull request
Jan 12, 2022
…light-client-verifier` (#1071) * Split out verifier parts of tendermint-light-client to tendermint-light-client-verifier * Add Time::now() method behind clock feature * light-client refactor: Re-export new verifier crate from `tendermint-light-client` (#1074) * Re-export tendermint_light_client_verifier as verifier from tendermint_light_client Signed-off-by: Thane Thomson <[email protected]> * Remove unnecessary tendermint-light-client import Signed-off-by: Thane Thomson <[email protected]> * Fix crate docs to reflect verifier extraction Signed-off-by: Thane Thomson <[email protected]> * Add changelog entry Signed-off-by: Thane Thomson <[email protected]> * Re-export the original exports in light-client crate Co-authored-by: Thane Thomson <[email protected]>
thanethomson
added a commit
that referenced
this pull request
Jan 12, 2022
…ht-client-verifier (Backported to v0.23) (#1072) * Split out verifier parts of tendermint-light-client to tendermint-light-client-verifier Rebased from master * Re-apply v0.23-specific changes * Missed patch in kvstore-test * Fix light-client-js test * Add Time::now() method behind clock feature * light-client refactor: Re-export new verifier crate from `tendermint-light-client` (#1074) * Re-export tendermint_light_client_verifier as verifier from tendermint_light_client Signed-off-by: Thane Thomson <[email protected]> * Remove unnecessary tendermint-light-client import Signed-off-by: Thane Thomson <[email protected]> * Fix crate docs to reflect verifier extraction Signed-off-by: Thane Thomson <[email protected]> * Add changelog entry Signed-off-by: Thane Thomson <[email protected]> * Re-export the original exports in light-client crate * light-client refactor: Merge latest changes from v0.23.x (#1075) * Merge latest changes from v0.23.x Signed-off-by: Thane Thomson <[email protected]> * Remove redundant imports from kvstore test Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Thane Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suggestions for #1071.
This PR re-exports the
tendermint-light-client-verifier
crate fromtendermint-light-client
to allow users of thetendermint-light-client
crate easy access to the verifier.It also adds some minor documentation updates and a changelog entry.
.changelog/