Recommend RPC-based pull event source over WebSocket-based push event source
#4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancazamfir
reviewed
Sep 17, 2024
| @@ -123,7 +123,7 @@ grpc_addr = 'http://127.0.0.1:9090' | |||
|
|
|||
| # Specify the WebSocket address and port where the chain WebSocket server | |||
| # listens on. Required | |||
| event_source = { mode = 'push', url = 'ws://127.0.0.1:26657/websocket', batch_delay = '500ms' } | |||
| event_source = { mode = 'pull', interval = '500ms', max_retries = 3 } | |||
There was a problem hiding this comment.
Comment above needs update.
|
As discussed in the IBC meeting:
|
ljoss17
reviewed
Oct 14, 2024
There was a problem hiding this comment.
What is the reason we recommend pull over push? I think we should write something either in a new section of the Configuration section, https://hermes.informal.systems/documentation/configuration/index.html, or if this is only related to performance it can also be added directly in the performance tuning section https://hermes.informal.systems/documentation/configuration/performance.html.
|
|
||
| # ... | ||
| ``` | ||
|
|
||
| > **Caution:** The "Basic" authentication scheme sends the credentials encoded but not encrypted. | ||
| > This would be completely insecure unless the exchange was over a secure connection (HTTPS/TLS). | ||
|
|
||
| ## Configuring Support for Wasm Relaying |
There was a problem hiding this comment.
Why is the entire block removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.