Migrate from tendermint-rs to cometbft-rs #3865
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to add a `features = ["clock"]` to the Cargo.toml which was not needed before. From what I can tell nothing changed in cometbft compared to tendermint crate features. One potential explanation is due to transitive dependencies. Crate ibc-telemetry depends on ibc-relayer-types which imports tendermint using `features = ["clock"]` and maybe this makes the feature available transivitely in telemetry. To investigate cc @mzabaluev
Multiple errors due to transitive dependencies on tendermint-rs via ibc-proto crate. Need to upgrade ibc-proto also.
13 tasks
The field is now named cometfbt_version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3820
Supersedes #3832
Requires cosmos/ibc-proto-rs#190
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.