Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary draft of architecture.md doc #1341

Closed
wants to merge 15 commits into from
Closed

Add preliminary draft of architecture.md doc #1341

wants to merge 15 commits into from

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented Sep 10, 2021

This is a preliminary draft of an architecture.md doc that aims to cover the overall high-level layout of the ibc-rs crate. I'm roughly following the same structure for this doc that rust-analyzer uses: https://github.com/rust-analyzer/rust-analyzer/blob/d7c99931d05e3723d878bea5dc26766791fa4e69/docs/dev/architecture.md.

Things I want to further flesh out with this doc include:

  • Adding more context on each of the sub-crates.
  • Adding in any additional modules that I didn't list here but that are also important to highlight.
  • Mention any architectural invariants that will likely hold in the long run.
  • Mention any cross-cutting concerns such as testing, observability, error handling, etc.

Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some ideas, I like where this is going!

@@ -6,48 +6,71 @@ This document describes the architecture of ibc-rs. If you're looking for a high

![](docs/architecture/assets/repo-context.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the picture is not rendered. I would find it useful if we do have an overview diagram, e.g., a system context diagram.

docs/architecture/architecture.md Outdated Show resolved Hide resolved
docs/architecture/architecture.md Outdated Show resolved Hide resolved
docs/architecture/architecture.md Outdated Show resolved Hide resolved
docs/architecture/architecture.md Outdated Show resolved Hide resolved
docs/architecture/architecture.md Outdated Show resolved Hide resolved
@adizere adizere mentioned this pull request Sep 30, 2021
12 tasks
@seanchen1991 seanchen1991 marked this pull request as ready for review October 5, 2021 17:38
@seanchen1991
Copy link
Contributor Author

Closing this PR and opening a new one because I accidentally deleted my fork 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants