Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update proto files for LSM #3

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Conversation

mpoke
Copy link
Collaborator

@mpoke mpoke commented Nov 27, 2023

Description

Closes: NA

Related: cosmos#18200

The feat/lsm/v0.47.x is pointing at release/v0.47.x@55c6d55c5583bacd37f6ddbe60570688edb81d76.

This PR brings cosmos#18313 to this repo to make it easier to finalize the upgrade. Update proto files and deprecate min-self-delegation.

Credits: @zmanian


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as first steps.

Feel free to merge so we can iterate.

@mpoke mpoke merged commit 2623645 into feat/lsm/v0.47.x Nov 27, 2023
13 of 25 checks passed
Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams"
Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend"
Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward"
Msg_WithdrawAllTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawAllTokenizeShareRecordReward"

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
Msg_FundCommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Msg/FundCommunityPool"
Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams"
Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend"
Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward"

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
@@ -29,6 +29,7 @@
Query_DelegatorValidators_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorValidators"
Query_DelegatorWithdrawAddress_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorWithdrawAddress"
Query_CommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Query/CommunityPool"
Query_TokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Query/TokenizeShareRecordReward"

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants