Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(staking): update 0.47-lsm with staking changes [change base] #1

Closed
wants to merge 3 commits into from
Closed

chore(staking): update 0.47-lsm with staking changes [change base] #1

wants to merge 3 commits into from

Conversation

MSalopek
Copy link

Description

Related: cosmos#18200

This PR brings cosmos#18313 to this repo to make it easier to finalize the upgrade.

Credits: @zmanian

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MSalopek MSalopek added the enhancement New feature or request label Nov 27, 2023
@MSalopek MSalopek requested review from mpoke and bermuell November 27, 2023 13:49
@MSalopek MSalopek self-assigned this Nov 27, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2023
View reviewed changes
api/cosmos/distribution/v1beta1/tx_grpc.pb.go
Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams"
Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend"
Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward"
Msg_WithdrawAllTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawAllTokenizeShareRecordReward"

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
api/cosmos/distribution/v1beta1/tx_grpc.pb.go
Msg_FundCommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Msg/FundCommunityPool"
Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams"
Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend"
Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward"

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
api/cosmos/distribution/v1beta1/query_grpc.pb.go
@@ -29,6 +29,7 @@
Query_DelegatorValidators_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorValidators"
Query_DelegatorWithdrawAddress_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorWithdrawAddress"
Query_CommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Query/CommunityPool"
Query_TokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Query/TokenizeShareRecordReward"

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2023
View reviewed changes
x/distribution/types/msg.go
func (msg MsgWithdrawTokenizeShareRecordReward) GetSigners() []sdk.AccAddress {
owner, err := sdk.AccAddressFromBech32(msg.OwnerAddress)
if err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
x/distribution/types/msg.go
func (msg MsgWithdrawAllTokenizeShareRecordReward) GetSigners() []sdk.AccAddress {
owner, err := sdk.AccAddressFromBech32(msg.OwnerAddress)
if err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@MSalopek
Copy link
Author

Closing in favor of #1 which is using cherry pick (history is cleaner).

@MSalopek MSalopek closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke Awaiting requested review from mpoke

@bermuell bermuell Awaiting requested review from bermuell

Assignees

@MSalopek MSalopek

Labels
C:CLI C:x/distribution C:x/staking enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSalopek @zmanian