-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove nested orgs labels route #19104
Conversation
b87bfa8
to
4167205
Compare
4167205
to
68b06b6
Compare
68b06b6
to
1fc5cb5
Compare
b4171fc
to
2345008
Compare
a914cea
to
e07c090
Compare
c13657e
to
6a40dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine, i'm hesitant to approve as i don't have context regarding the snippet you posted in your other pr. Maybe @ebb-tide would be able to confidently say whether this would have any ill effects or not (tests seem to pass so i'd say ✔️, but they've missed things before)
This code is not behind a feature flag, as the route that this label handler was supporting is not functional currently and is not being used in our UIs. Instead of returning an empty array of labels, this route will now return a 404.
6a40dd4
to
5b2d33f
Compare
Nvm, I was using an older Cloud 2 cluster that didn't have the latest changes. |
This PR removes an outdated swagger definition for the orgs/orgID/labels route which was not being used, and removes the label handler from the org handler to reflect this change.
Continuation of #19102