-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pandas 3.0 warning for inplace method #642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lars20070, first off, thank you for your contribution through the PR, it's greatly appreciated! 👍
Could you please explain why Pandas recommends using the syntax: For example, when doing 'df[col].method(value, inplace=True)', try using 'df.method({col: value}, inplace=True)'
?
It seems our sources employ this recommended syntax.
Best Regards
Hi @bednar, Pandas is currently in version 2.2 with 3.0 scheduled for April 2024. No, I cannot explain why Pandas triggered the warning. But you might be on the safe side using option 2 and be prepared for the upcoming breaking changes. I can see your #638 changes but still get the warning from this line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lars20070,
Thank you for your thorough explanation and for aligning your solution with best practices recommended by Pandas.
Before we proceed to merge your PR, could you please ensure that all items on our project's Checklist are satisfied?
After that we are be able to merge this PR.
Thanks again for your contribution 👍
@bednar I struggle a bit to understand your setup. I am more familiar with Poetry projects. I would appreciate your input.
Can you please explain what changes in the code are needed. I cannot see any merge conflicts or failing tests. Thanks. |
@lars20070, please sign the CLA and check the checkbox so we can proceed with merging your PR. |
Signed. Thanks @bednar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
On a totally unrelated note. Any chance of looking into this issue? |
@lars20070 unfurnetally I don't know anything about |
Related #637
Proposed Changes
Currently, the following warning for inplace methods in the upcoming Pandas 3.0 is triggered.
The pull request silences the warning.
Checklist
pytest tests
completes successfully