Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging http requests without query parameters #631

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jan 17, 2024

Closes #630

Proposed Changes

Fixed logging HTTP requests without query parameters.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7181fa) 90.36% compared to head (6c8814b) 90.39%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
+ Coverage   90.36%   90.39%   +0.02%     
==========================================
  Files          39       39              
  Lines        3497     3497              
==========================================
+ Hits         3160     3161       +1     
+ Misses        337      336       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review January 17, 2024 13:30
@bednar bednar requested a review from karel-rehor January 17, 2024 13:30
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit

@bednar bednar added this to the 1.40.0 milestone Jan 29, 2024
@bednar bednar merged commit 4f1ab87 into master Jan 29, 2024
15 checks passed
@bednar bednar deleted the logging-requests-without-query-parameters branch January 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping throwing exception when DEBUG is True
3 participants