Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DataFrame write shows Future Warning. #611

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

xxjjvxb
Copy link
Contributor

@xxjjvxb xxjjvxb commented Sep 10, 2023

Closes #610

Proposed Changes

use iloc

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1ec64b7) 90.30% compared to head (12f1973) 90.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          39       39           
  Lines        3456     3456           
=======================================
  Hits         3121     3121           
  Misses        335      335           
Files Changed Coverage Δ
...fluxdb_client/client/write/dataframe_serializer.py 98.26% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

LGTM 🚀

@bednar bednar changed the title DataFrame write shows Future Warning. fix: DataFrame write shows Future Warning. Sep 11, 2023
@bednar bednar merged commit aa6e5c4 into influxdata:master Sep 11, 2023
1 of 2 checks passed
@bednar bednar added this to the 1.38.0 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated warning when write DataFrame
3 participants