Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to the latest swagger API #588

Merged
merged 4 commits into from
Jul 1, 2023
Merged

chore: update to the latest swagger API #588

merged 4 commits into from
Jul 1, 2023

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 30, 2023

Closes #587

Proposed Changes

Use the latest InfluxDB API definitions for generated APIs with following breaking changes:

  • User, UserResponse, ResourceMember and ResourceOwner classes no longer supports oauth_id field
  • Task class no longer supports type field
  • ScriptUpdateRequest class no longer supports name field
  • UsersService.get_flags operation is moved to ConfigService

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review June 30, 2023 06:52
@bednar bednar requested a review from powersj June 30, 2023 06:52
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0be41d1) 90.30% compared to head (eb84adc) 90.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          39       39           
  Lines        3456     3456           
=======================================
  Hits         3121     3121           
  Misses        335      335           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

As you called out there are some breaking changes, but we are also breaking users by not having the latest API as well. I have gone through most of this, majority of which is comment or noqa.

@bednar
Copy link
Contributor Author

bednar commented Jul 1, 2023

Yes, indeed, breaking changes will not affect 99.99% of users.

@bednar bednar merged commit a4c5746 into master Jul 1, 2023
@bednar bednar deleted the update-api branch July 1, 2023 09:16
@bednar bednar added this to the 1.35.0 milestone Jul 1, 2023
@bednar bednar modified the milestones: 1.35.0, 1.37.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication Create/Update Request is Missing the 'maxAgeSeconds' Parameter
3 participants