Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception propagation for asynchronous QueryApi #512

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 7, 2022

Closes #511

Proposed Changes

Fixed exception propagation for asynchronous QueryApi. Others async APIs works correctly.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar requested a review from powersj October 7, 2022 12:21
@bednar bednar self-assigned this Oct 7, 2022
@bednar bednar marked this pull request as ready for review October 7, 2022 12:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Base: 90.11% // Head: 90.16% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (7dbf563) compared to base (50f021e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   90.11%   90.16%   +0.04%     
==========================================
  Files          39       39              
  Lines        3380     3387       +7     
==========================================
+ Hits         3046     3054       +8     
+ Misses        334      333       -1     
Impacted Files Coverage Δ
influxdb_client/client/query_api_async.py 100.00% <100.00%> (ø)
influxdb_client/_async/rest.py 79.03% <0.00%> (+0.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! This will make things more clear.

@bednar bednar force-pushed the async-exception-query-propagation branch from 7dbf563 to 696da81 Compare October 12, 2022 04:10
@bednar bednar merged commit ddb0f77 into master Oct 12, 2022
@bednar bednar deleted the async-exception-query-propagation branch October 12, 2022 04:17
@bednar bednar added this to the 1.34.0 milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message with async client
3 participants