-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): improve Query UX #450
Conversation
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 89.35% 89.39% +0.04%
==========================================
Files 38 39 +1
Lines 3260 3301 +41
==========================================
+ Hits 2913 2951 +38
- Misses 347 350 +3
Continue to review full report at Codecov.
|
Hi @Anaisdg, @Jayclifford345, Can you take a look to this PR as a solution for #445 and #446? Regards |
@bednar It looks really great! Thank you so much! |
@Anaisdg thanks |
I haven't started digging into queries with the library. However, do either of these break backward compatibility? |
It is backward compatible change because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is backward compatible change
great, should this be part of the release this week then?
Yes, it will be part of it. |
Closes #445
Closes #446
Proposed Changes
query()
function returnsTableList
instead ofList['FluxTable']
,query_csv()
function returnsCSVIterator
instead ofcsv.reader
=> we are able to add additional functions for better procession of the query resultslist
of values and JSON:list
of values and optionally spit out the headers:query_data_frame()
function contains warning and updated doc about usingpivot() function
to optimal shaping of query resultsChecklist
pytest tests
completes successfully