Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct serialization empty columns into LineProtocol [DataFrame] #359

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 10, 2021

Related to https://community.influxdata.com/t/writing-entries-gives-invalid-field-format-error-but-only-if-2-tags-are-added-together-separately-works-fine/22368

Proposed Changes

Fixed regexp for removing leading comma for NaN values.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar changed the title fix: regexp for remove leading comma for NaN values fix: regexp for remove leading comma for NaN values Nov 10, 2021
@bednar bednar changed the title fix: regexp for remove leading comma for NaN values fix: correct serialization empty columns into LineProtocol [DataFrame] Nov 10, 2021
@bednar bednar marked this pull request as ready for review November 10, 2021 10:11
@bednar bednar requested a review from rhajek November 10, 2021 10:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #359 (1fbd754) into master (81e7d21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          27       27           
  Lines        2324     2325    +1     
=======================================
+ Hits         2157     2158    +1     
  Misses        167      167           
Impacted Files Coverage Δ
...fluxdb_client/client/write/dataframe_serializer.py 98.03% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e7d21...1fbd754. Read the comment docs.

@bednar bednar force-pushed the fix/dataframe-lp-empty branch from 51965fe to 1fbd754 Compare November 11, 2021 12:44
@bednar bednar added this to the 1.24.0 milestone Nov 11, 2021
@bednar bednar added the bug Something isn't working label Nov 11, 2021
@bednar bednar merged commit 500835f into master Nov 11, 2021
@bednar bednar deleted the fix/dataframe-lp-empty branch November 11, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants