-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set proxy server in config file #283
Conversation
The proxy option was not parsed in the config file.
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 92.42% 92.38% -0.04%
==========================================
Files 27 27
Lines 2165 2168 +3
==========================================
+ Hits 2001 2003 +2
- Misses 164 165 +1
Continue to review full report at Codecov.
|
I had a bit of a headache today figuring out why I couldn't connect to my InfluxDB server from behind a proxy. I fixed it for the config.ini, but I would also take into account http_proxy and HTTP_PROXY environment variables if they are set, with lower precedence (these are now ignored) Since there are some options how to deal with that, I'll leave that one up to you guys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR 👍
Could you please satisfy next requirements before we merge the PR into master:
- Add test for
proxy
configuration: https://github.com/dstaesse/influxdb-client-python/blob/adcb7bed4428bab5937c6bea2131628839f924c1/tests/test_InfluxDBClient.py#L65 - Sign CLA:
7b17e66
to
5c05089
Compare
Sure. |
I looked for a valid proxy configuration for the integration tests, but it looks like there is no test yet for the proxy feature as a whole... |
5c05089
to
e3aaecd
Compare
Your test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dstaesse thanks again for your PR! 👍 Let's merge it into master.
The proxy option was not parsed in the config file.
Closes #
Proposed Changes
Briefly describe your proposed changes:
Checklist
pytest tests
completes successfully