Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: field string values are correctly escaped in DataFrame serialization #154

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 14, 2020

Closes #153

Proposed Changes

  • string fields are correctly serialized

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review September 14, 2020 05:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   89.15%   89.15%           
=======================================
  Files          25       25           
  Lines        1918     1918           
=======================================
  Hits         1710     1710           
  Misses        208      208           
Impacted Files Coverage Δ
...fluxdb_client/client/write/dataframe_serializer.py 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0224ad7...20b484c. Read the comment docs.

@bednar bednar merged commit 0ded779 into master Sep 14, 2020
@bednar bednar deleted the fix/dataframe-field-string branch September 14, 2020 11:31
@bednar bednar added this to the 1.11.0 milestone Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String column changed in DataFrame Write
3 participants