Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added SetupWithToken() method, allowing users to specify Admin token … #328

Merged
merged 1 commit into from
May 20, 2022

Conversation

AnalogJ
Copy link
Contributor

@AnalogJ AnalogJ commented May 18, 2022

added SetupWithToken() method, allowing users to specify Admin token during initialization.

Closes #327

Proposed Changes

Add SetupWithToken() method, clone of Setup() method with additional token parameter.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

client.go Outdated Show resolved Hide resolved
@vlastahajek
Copy link
Contributor

vlastahajek commented May 19, 2022

Thanks for the PR! Just a small change in code. And, please, make the commit message semantic.

@vlastahajek vlastahajek changed the title added SetupWithToken() method, allowing users to specify Admin token … feat: added SetupWithToken() method, allowing users to specify Admin token … May 19, 2022
@vlastahajek
Copy link
Contributor

I plan to create a new release of this library on Friday the 20th. If you manage to amend this PR today, it will be in this release.

@AnalogJ
Copy link
Contributor Author

AnalogJ commented May 19, 2022

Unfortunately I'm traveling right now and will be unable to update this PR before Friday.

@AnalogJ AnalogJ requested a review from vlastahajek May 20, 2022 00:24
@vlastahajek
Copy link
Contributor

Thanks for the quick update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

influx setup cli command supports --token flag, Setup() function does not
2 participants