Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: server state check functions improvements #285

Merged
merged 5 commits into from
Nov 15, 2021
Merged

feat: server state check functions improvements #285

merged 5 commits into from
Nov 15, 2021

Conversation

vlastahajek
Copy link
Contributor

@vlastahajek vlastahajek commented Nov 11, 2021 •
edited
Loading

Closes #284

Proposed Changes

Improving server state functions:

  • added Ping() - the only way how to check Cloud server state (Client interface breaking change)
  • Health() and Ready() fails when connecting to Cloud
  • Ready() returns server uptime info, instead of bool (Compatibility Breaking Change )

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format

@vlastahajek vlastahajek changed the title Feat/ping feat: server state check functions improvements Nov 11, 2021
@vlastahajek vlastahajek requested a review from sranka November 11, 2021 12:35
sranka
sranka approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@sranka sranka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, expect a few nits.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
api/write_test.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
@vlastahajek vlastahajek merged commit 749020a into influxdata:master Nov 15, 2021
@vlastahajek vlastahajek deleted the feat/ping branch November 15, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Health() and Ready() must fail when connecting to InfluxDB cloud
2 participants
@vlastahajek @sranka