Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove link to QueryTableResult #218

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

soolaugust
Copy link
Contributor

@soolaugust soolaugust commented Dec 15, 2020

As future change, remove link of QueryTableResult as it's unnecessary

Proposed Changes

current link of QueryTableResult is wrong. should fix it.

@soolaugust soolaugust changed the title Fix wrong link in README.md docs: Fix wrong link in README.md Dec 15, 2020
@vlastahajek
Copy link
Contributor

@soolaugust, thanks for the PR! Please, rebase your branch and fix the commit message.

@sranka
Copy link
Contributor

sranka commented Dec 16, 2020

This PR references a specific commit, it is stable but it can get old without a notice. I think that it would be better to simply use QueryTableResult. Rationale: A specific link to the structure does not explain how to use it. A link to documentation, or an example can.

@soolaugust
Copy link
Contributor Author

@sranka I agree with you. actually the following codes has explained how to use QueryTableResult. maybe the link is unnecessary. If developers want to know the detail, they will check the codes.

@soolaugust soolaugust changed the title docs: Fix wrong link in README.md docs: remove link of QueryTableResult Dec 16, 2020
@sranka sranka changed the title docs: remove link of QueryTableResult docs: remove link to QueryTableResult Dec 16, 2020
README.md Outdated Show resolved Hide resolved
@vlastahajek vlastahajek merged commit 3c93fc0 into influxdata:master Dec 17, 2020
@soolaugust soolaugust deleted the patch-1 branch December 17, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants