fix: Allow connecting to a server on a URL path (#149) #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlastahajek
changed the title
sranka
requested changes
Jul 15, 2020
| {"http://host:9999/", "http://host:9999/api/v2/", "http://host:9999/api/v2/write"}, | ||
| {"http://host:9999/path", "http://host:9999/path/api/v2/", "http://host:9999/path/api/v2/write"}, | ||
| {"http://host:9999/path/", "http://host:9999/path/api/v2/", "http://host:9999/path/api/v2/write"}, | ||
| {"http://host:9999/path1/path2/path3", "http://host:9999/path1/path2/path3/api/v2/", "http://host:9999/path1/path2/path3/api/v2/write"}, |
There was a problem hiding this comment.
this line (and the next one, which is the same) is IMHO redundant
There was a problem hiding this comment.
/path1/path2/path3 is tested as a more complex path and they differ in the '/' at the end
| @@ -42,7 +71,7 @@ func TestServerError429(t *testing.T) { | |||
| w.Header().Set("Retry-After", "1") | |||
| w.Header().Set("Content-Type", "application/json") | |||
| w.WriteHeader(http.StatusTooManyRequests) | |||
| w.Write([]byte(`{"code":"too many requests", "message":"exceeded rate limit"}`)) | |||
| _, _ = w.Write([]byte(`{"code":"too many requests", "message":"exceeded rate limit"}`)) | |||
There was a problem hiding this comment.
Why these blanks? Probably a violation of https://staticcheck.io/docs/checks#S1005
There was a problem hiding this comment.
Explicitly noting about ignoring returned val and returned error recommended by the style check in the IDE.
It's validated by running full profile staticcheck ('staticcheck -show-ignored -checks="all" ./...') and this case is ok
| func TestServerErrorNonJSON(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| time.Sleep(100 * time.Millisecond) | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| w.Write([]byte(`internal server error`)) | ||
| _, _ = w.Write([]byte(`internal server error`)) |
There was a problem hiding this comment.
| @@ -79,7 +124,7 @@ func TestServerErrorInflux1_8(t *testing.T) { | |||
| w.Header().Set("X-Influxdb-Error", "bruh moment") | |||
| w.Header().Set("Content-Type", "application/json") | |||
| w.WriteHeader(404) | |||
| w.Write([]byte(`{"error": "bruh moment"}`)) | |||
| _, _ = w.Write([]byte(`{"error": "bruh moment"}`)) | |||
There was a problem hiding this comment.
sranka
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149
Properly concatenating URL path to the final API endpoint