Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: QueryApi, WriteApi, WriteApiBlocking and related objects moved into api #125

Merged

Conversation

vlastahajek
Copy link
Contributor

Refactor towards consistent API.

WriteApi,WriteApiBlocking,QueryApi interfaces and related objects like Point, FluxTableMetadata, FluxTableColumn, FluxRecord, moved to the api ( and api/write, api/query) packages.

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass

@codecov-io
Copy link

Codecov Report

Merging #125 into master will decrease coverage by 45.29%.
The diff coverage is 49.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #125       +/-   ##
===========================================
- Coverage   86.81%   41.51%   -45.30%     
===========================================
  Files          10       20       +10     
  Lines         781     1438      +657     
===========================================
- Hits          678      597       -81     
- Misses         70      815      +745     
+ Partials       33       26        -7     
Impacted Files Coverage Δ
api/query/table.go 43.42% <0.00%> (ø)
api/write/options.go 0.00% <0.00%> (ø)
api/write/point.go 92.94% <ø> (ø)
internal/write/writeService.go 0.00% <0.00%> (ø)
options.go 20.00% <14.81%> (-49.24%) ⬇️
compatibility.go 50.00% <50.00%> (ø)
internal/write/queue.go 85.00% <60.00%> (ø)
api/write.go 90.75% <85.00%> (ø)
api/query.go 82.67% <100.00%> (ø)
api/write/ext.go 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98dc31e...ec7cde7. Read the comment docs.

@vlastahajek vlastahajek merged commit a4c1872 into influxdata:master May 15, 2020
@vlastahajek vlastahajek deleted the refactor/query-and-write-to-apis branch May 15, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants