Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(iox-11398): patched df upgrade 2024-07-13 #35

Closed
wants to merge 7 commits into from

Conversation

appletreeisyellow
Copy link

@appletreeisyellow appletreeisyellow commented Jul 22, 2024

⚠️ This will not be merged. ⚠️

  1. Bringing us up to datafusion to 2024-07-13, apache@a7041fe

  2. This PR is based on 2024-07-08 apache@4123ad6

    git co -b chunchun/update-df-july-week-2 4123ad6ca7bb7bdcb4cca65e97d30b4677233de3
    
  3. Cherry-picked the following commits:

    1. feat: add UDF to_local_time() apache/datafusion#11347 / apache@f284e3b

      commit f284e3bb73e089abc0c06b3314014522411bf1da
      Author: Chunchun Ye <[email protected]>
      Date:   Thu Jul 11 11:17:09 2024 -0500
      
          feat: add UDF to_local_time() (#11347)
    2. Track parquet writer encoding memory usage on MemoryPool apache/datafusion#11345 / apache@6038f4c

      commit 6038f4cfac536dbb54ea2761828f7344a23b94f0
      Author: wiedld <[email protected]>
      Date:   Wed Jul 10 11:21:01 2024 -0700
      
          Track parquet writer encoding memory usage on MemoryPool (#11345)
    3. fix(11397): surface proper errors in ParquetSink apache/datafusion#11399 / apache@1dfac86

      commit 1dfac86a89750193491cf3e04917e37b92c64ffa
      Author: wiedld <[email protected]>
      Date:   Fri Jul 12 04:04:42 2024 -0700
      
          fix(11397): surface proper errors in ParquetSink (#11399)
    4. temporary workaround: Test + workaround for SanityCheckPlan error apache/datafusion#11493

      commit 73196fdb7ef4dbb6e24d653cd18d4b0cc70a3474
      Author: Andrew Lamb <[email protected]>
      Date:   Tue Jul 16 12:14:19 2024 -0400
      
          Test + workaround for SanityCheck plan

appletreeisyellow and others added 5 commits July 22, 2024 10:07
* feat: add UDF `to_local_time()`

* chore: support column value in array

* chore: lint

* chore: fix conversion for us, ms, and s

* chore: add more tests for daylight savings time

* chore: add function description

* refactor: update tests and add examples in description

* chore: add description and example

* chore: doc

chore: doc

chore: doc

chore: doc

chore: doc

* chore: stop copying

* chore: fix typo

* chore: mention that the offset varies based on daylight savings time

* refactor: parse timezone once and update examples in description

* refactor: replace map..concat with flat_map

* chore: add hard code timestamp value in test

chore: doc

chore: doc

* chore: handle errors and remove panics

* chore: move some test to slt

* chore: clone time_value

* chore: typo

---------

Co-authored-by: Andrew Lamb <[email protected]>
* feat(11344): track memory used for non-parallel writes

* feat(11344): track memory usage during parallel writes

* test(11344): create bounded stream for testing

* test(11344): test ParquetSink memory reservation

* feat(11344): track bytes in file writer

* refactor(11344): tweak the ordering to add col bytes to rg_reservation, before selecting shrinking for data bytes flushed

* refactor: move each col_reservation and rg_reservation to match the parallelized call stack for col vs rg

* test(11344): add memory_limit enforcement test for parquet sink

* chore: cleanup to remove unnecessary reservation management steps

* fix: fix CI test failure due to file extension rename
* fix(11397): do not surface errors for closed channels, and instead let the task join errors be surfaced

* fix(11397): terminate early on channel send failure
@appletreeisyellow appletreeisyellow changed the title WIP(iox-11398): patched df upgrade 2024-07-TBD WIP(iox-11398): patched df upgrade 2024-07-13 Jul 22, 2024
@appletreeisyellow
Copy link
Author

closing since the upgrade is done

@appletreeisyellow appletreeisyellow deleted the chunchun/update-df-july-week-2 branch August 6, 2024 18:49
wiedld pushed a commit that referenced this pull request Oct 4, 2024
…pache#12705)

* Support unparsing plans with both Aggregation and Window functions (#35)

* Fix unparsing for aggregation grouping sets

* Add test for grouping set unparsing

* Update datafusion/sql/src/unparser/utils.rs

Co-authored-by: Jax Liu <[email protected]>

* Update datafusion/sql/src/unparser/utils.rs

Co-authored-by: Jax Liu <[email protected]>

* Update

* More tests

---------

Co-authored-by: Jax Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants