feat: scala 3 derivation #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i10416
commented
Dec 14, 2024
i10416
commented
Dec 14, 2024
| @@ -9,12 +9,12 @@ trait Codec[A] { | |||
| defaults: Codec.Defaults, | |||
| index: Int | |||
| ): Either[Parse.Error, A] | |||
| private[toml] def optional: Boolean = false | |||
There was a problem hiding this comment.
This field makes it easier to handle default value for missing field. toml does not have the concept of null or nil, so we cannot simply convert null into NullValue like AST node.
i10416
commented
Dec 14, 2024
| import org.scalatest.funsuite.AnyFunSuite | ||
| import toml._, derivation.auto._ | ||
|
|
||
| trait CodecSpecExtras {self: CodecSpec => |
There was a problem hiding this comment.
cannot pass this test yet... I hope someone will solve it in the future.
There was a problem hiding this comment.
Anyway, you can now enjoy most of the niceties of codec derivation.
i10416
commented
Dec 14, 2024
| case None => | ||
| Right( | ||
| d.defaultParams.get(witnessName) | ||
| .map(_.asInstanceOf[t]) |
There was a problem hiding this comment.
defaultParams is Map[Strng, Any], so you need asInstanceOf
i10416
commented
Dec 14, 2024
| .left.map((a,m) => (witnessName +: a, m)) | ||
| case None => | ||
| d.defaultParams.get(witnessName) match | ||
| case None if codec.optional => Right(None.asInstanceOf[t]) |
There was a problem hiding this comment.
optional returns true if and only if codec is of type Codec[Option[?]], so it is safe to use None.asInstanceOf[t] where t is of type Option[?].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5
This PR adds Scala 3 derivation.
Supported features are
OptionfieldIt pass all the test except one which uses recursive type, optional value and default value.
I keep it as is in the hope that someone will solve the problem in the future...
See core/src/test/scala-3/toml/CodecSpec.scala.