Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to new version of npm package #147

Merged
merged 1 commit into from
Jan 12, 2019

Conversation

johanbrandhorst
Copy link
Contributor

@jonny-improbable
Copy link
Contributor

Thanks @johanbrandhorst; build is failing because the examples need to be re-generated, please could you run ./generate.sh and check in the changed files?

Also, from looking at the package.json file I can see that it incldues grpc-web-client as a devDependency; please could you run the following commands in the root of the repo:

nvm use  # to ensure you are using the node/npm version specified in `.npmrc`
npm rm grpc-web-client
npm install @improbable-eng/grpc-web

Thanks!

@johanbrandhorst
Copy link
Contributor Author

Had to run yarn remove and yarn add as well but I think I got all of them now!

import {
UserServiceClient,
GetUserRequest
} from "../generated/users_pb_service";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my markdown formatter, prettier, I can remove these changes if you want.

Copy link
Contributor

@jonny-improbable jonny-improbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks :)

@jonny-improbable jonny-improbable merged commit dd6273b into improbable-eng:master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants