[New] no-namespace: Add ignore option
#2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes import-js#1916. Closes import-js#1903.
|
Hi @aberezkin, any updates on that ? Have the same problem with this rule. |
|
Hi @gairon. I would be happy to provide some update but I can't merge it myself since I'm not a maintainer 😄 |
|
Who else can help with verifying and pushing a really cool feature? |
ljharb
requested changes
Aug 6, 2021
aberezkin
force-pushed
the
ignore-from-pattern-for-no-namespace
branch
from
7e191f5 to
94ab4d5
Compare
ljharb
reviewed
Aug 6, 2021
|
@ljharb Fixed! :) |
ljharb
changed the title
no-namespace: Add ignore option
ljharb
approved these changes
Aug 7, 2021
ljharb
force-pushed
the
ignore-from-pattern-for-no-namespace
branch
from
982c0ee to
bba59c4
Compare
|
Hi @aberezkin, |
ljharb
added a commit
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1916
Closes #1903
Hi, we want to use the rule
no-namespacein our project but we have ai18ncodegen tool that forces us to use wildcard imports for certain files that follow some pattern (\S+\.i18n, to be precise). Also I've seen that there's people with similar issue.I thought that we can implement something similar to
argsIgnorePattern/varsIgnorePatternin core eslint rules.I made a test for that case and updated the docs as well. Please let me know if there's something else I should do to get this merged.