Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hash-based image identifier to prevent caching, use colored background for icon fallback #433

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

daniel-mader
Copy link
Collaborator

@daniel-mader daniel-mader commented Dec 5, 2024

Description of change

  • use hash-based image identifier to prevent caching
  • use colored background for icon fallback

Links to any relevant issues

How the change has been tested

Successfully running in v0.7.3

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader added Bug Something isn't working Enhancement New feature or improvement to an existing feature labels Dec 5, 2024
@daniel-mader daniel-mader self-assigned this Dec 5, 2024
@daniel-mader daniel-mader marked this pull request as ready for review December 5, 2024 11:27
Copy link
Member

@maiertech maiertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add 2 comments.

@daniel-mader daniel-mader merged commit 8eb57e7 into dev Dec 6, 2024
3 checks passed
@daniel-mader daniel-mader deleted the fix/image-issues-rebased branch December 6, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants