Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JointStatePublisher publish parent, child and axis data #1345

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 16, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

JointStatePublisher plugin is not publishing data about child, parent or axis.

This PR add this data to the message

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Feb 16, 2022
@ahcorde ahcorde requested a review from chapulina as a code owner February 16, 2022 14:25
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Feb 16, 2022
@adlarkin adlarkin self-requested a review February 16, 2022 17:14
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1345 (89b52b3) into ign-gazebo3 (7b4fcda) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 89b52b3 differs from pull request most recent head 951cda3. Consider uploading reports for the commit 951cda3 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1345      +/-   ##
===============================================
+ Coverage        77.71%   77.74%   +0.02%     
===============================================
  Files              248      248              
  Lines            14223    14239      +16     
===============================================
+ Hits             11054    11070      +16     
  Misses            3169     3169              
Impacted Files Coverage Δ
...stems/joint_state_publisher/JointStatePublisher.cc 86.60% <100.00%> (+2.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4fcda...951cda3. Read the comment docs.

@ahcorde ahcorde requested a review from mjcarroll February 16, 2022 23:15
@ahcorde ahcorde merged commit 08a0dfc into ign-gazebo3 Feb 17, 2022
@ahcorde ahcorde deleted the ahcorde/3/imporve_joint_state_pub branch February 17, 2022 08:30
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants