-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new CMake policy to fix protobuf compilation #1046
Conversation
Signed-off-by: Jorge Perez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with happy CI.
Codecov Report
@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
- Coverage 63.71% 63.70% -0.01%
==========================================
Files 257 257
Lines 20064 20064
==========================================
- Hits 12783 12782 -1
- Misses 7281 7282 +1
Continue to review full report at Codecov.
|
Both of these jobs run on top of this PR: https://build.osrfoundation.org/job/ign_gazebo-pr-win/3151/ and https://build.osrfoundation.org/job/ign_gazebo-pr-win/3154/ and neither have the Protobuf CMake error. I think this is ready to merge and backport, I'll keep an eye to CI after this is merged as well. |
Signed-off-by: Jorge Perez <[email protected]> Signed-off-by: William Lew <[email protected]>
Signed-off-by: Jorge Perez [email protected]
🦟 Bug fix
Fixes #990
Summary
Discussion is provided in the original ticket.
Checklist
codecheck
passed (See contributing)