Fix protobuf dependency

[Blast545]

Signed-off-by: Jorge Perez [email protected]

🦟 Bug fix

Fixes gazebosim/gz-sim#990

Summary

This is a continuation of gazebosim/gz-sim#1046. The original fix solved issues with the ign-gazebo jobs of the ignition buildfarm, but the pr jobs still have this problem.

Currently the error appears only in win-windows_nuc.win10. I'll test ign-gazebo-pr-win job to get this issue addressed.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #277 (c617752) into ign-transport11 (f3c8f8b) will increase coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           ign-transport11     #277      +/-   ##
===================================================
+ Coverage            89.07%   89.09%   +0.02%     
===================================================
  Files                   51       51              
  Lines                 4769     4769              
===================================================
+ Hits                  4248     4249       +1     
+ Misses                 521      520       -1     

Impacted Files	Coverage Δ
include/ignition/transport/Discovery.hh	87.26% <0.00%> (+0.20%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c8f8b...c617752. Read the comment docs.

[Blast545]

Running CI for ign-gazebo6 including this PR:

• WIndows

[Blast545]

The protobuf error only occurs with win-windows_nuc.win10, this one is used by default with the PR jobs. So I'll use that one for testing this PR.

• WIndows

Another retry (because is a flaky problem, in the pr jobs seems to ocurr 4/5 times):

• WIndows (ugh)

[Blast545]

I have a clue about what might be happening, I'll give another shot at ign-gazebo, keeping this as a draft for now.

After pushing for this PR: gazebosim/gz-sim#1168
I realized it still complains about the dependency at the ign-transport level, so I'll apply that fix to this PR and see if it works.

[Blast545]

Another attempt:

• WIndows

OK, this one looks good because the output has warning from protobuf being imported. I'll run a coupe of attempts with the pr job before marking as ready to review.

[Blast545]

Ign-gazebo-pr-win job

• WIndows

[chapulina]

@Blast545 , is this PR still relevant?

[Blast545]

It's not relevant anymore, I'll close it! 👍

[chapulina]

Great, thanks! Can gazebosim/gz-sim#990 be closed?

[Blast545]

Yes, just closed! 🙌