Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not proxy sentry dsn (backport #4359) #4364

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 17, 2024

Due to the way the Sentry client parses the DSN, it isn't possible to use a proxy.
Otherwise, the request will all fail due to a wrong DSN.
We should just hardcode it in ignite, which is fine IMHO as sentry doesn't deprecate the DSN.
I have seen other open source Go project do the same.

Opened https://github.com/ignite/infraconfig/pull/6 to delete the proxy from infra.


This is an automatic backport of pull request #4359 done by Mergify.

* chore: do not proxy sentry dsn

* linting

* lint

(cherry picked from commit 3fb433d)

# Conflicts:
#	ignite/cmd/testnet_inplace.go
Copy link
Contributor Author

mergify bot commented Sep 17, 2024

Cherry-pick of 3fb433d has failed:

On branch mergify/bp/release/v28.x.y/pr-4359
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 3fb433d5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ignite/cmd/ignite/main.go
	modified:   ignite/internal/analytics/analytics.go
	modified:   ignite/pkg/announcements/announcement.go
	modified:   ignite/pkg/sentry/sentry.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/cmd/testnet_inplace.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@julienrbrt
Copy link
Member

Too late mergify :D Dup of #4363

@julienrbrt julienrbrt closed this Sep 17, 2024
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4359 branch September 17, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant