chore: do not proxy sentry dsn (backport #4359) #4364
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way the Sentry client parses the DSN, it isn't possible to use a proxy.
Otherwise, the request will all fail due to a wrong DSN.
We should just hardcode it in ignite, which is fine IMHO as sentry doesn't deprecate the DSN.
I have seen other open source Go project do the same.
Opened https://github.com/ignite/infraconfig/pull/6 to delete the proxy from infra.
This is an automatic backport of pull request #4359 done by Mergify.