Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename apps to extensions #4238

Closed
wants to merge 12 commits into from
Closed

Conversation

julienrbrt
Copy link
Member

Closes: #4235

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Jul 3, 2024
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. type:internal labels Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Visit the preview URL for this PR (updated for commit deb9f16):

https://igntservices-docs--pr4238-julien-extensions-pxr7efd9.web.app

(expires Fri, 09 Aug 2024 14:18:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@julienrbrt julienrbrt marked this pull request as ready for review July 3, 2024 19:59
docs/versioned_docs/version-v28/apps/01-using-apps.md Outdated Show resolved Hide resolved
docs/versioned_docs/version-v28/apps/01-using-apps.md Outdated Show resolved Hide resolved
docs/versioned_docs/version-v28/apps/01-using-apps.md Outdated Show resolved Hide resolved
docs/versioned_docs/version-v28/apps/01-using-apps.md Outdated Show resolved Hide resolved
ignite/services/plugin/template/main.go.plush Outdated Show resolved Hide resolved
@julienrbrt julienrbrt requested a review from salmad3 July 4, 2024 10:34
toschdev
toschdev previously approved these changes Jul 4, 2024
salmad3
salmad3 previously approved these changes Jul 8, 2024
@salmad3
Copy link
Member

salmad3 commented Jul 8, 2024

I believe test is failing because error message still uses "app"

Pantani
Pantani previously approved these changes Jul 8, 2024
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

The only thing I saw in the code is that the integration test folder is still integration/plugin. We can move to integration/extension

@julienrbrt
Copy link
Member Author

True, I'll fix!

Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignite/config/plugins/testdata/other/extensions.yml content is also wrong

extensions:
  - name: plugin1
    path: /path/to/plugin1
  - name: plugin2
    path: /path/to/plugin2
    with:
      foo: bar
      bar: baz

Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt julienrbrt dismissed stale reviews from Pantani, salmad3, and toschdev via 0df3f1b July 8, 2024 12:19
salmad3
salmad3 previously approved these changes Jul 9, 2024
@julienrbrt julienrbrt marked this pull request as draft July 9, 2024 10:09
@julienrbrt julienrbrt marked this pull request as ready for review July 10, 2024 19:57
@julienrbrt julienrbrt enabled auto-merge (squash) July 11, 2024 08:20
Pantani
Pantani previously approved these changes Jul 11, 2024
@julienrbrt julienrbrt disabled auto-merge July 15, 2024 11:02
Pantani
Pantani previously approved these changes Jul 15, 2024
@Pantani Pantani requested review from toschdev and salmad3 July 15, 2024 18:38
@Pantani Pantani self-requested a review July 25, 2024 20:44
Pantani
Pantani previously approved these changes Jul 25, 2024
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still have some merge conflicts

@julienrbrt julienrbrt requested a review from Pantani August 1, 2024 21:57
@julienrbrt julienrbrt enabled auto-merge (squash) August 1, 2024 21:57
@julienrbrt julienrbrt disabled auto-merge August 6, 2024 13:15
@julienrbrt julienrbrt closed this Aug 6, 2024
@julienrbrt
Copy link
Member Author

We have discussed internally that we'll not proceed yet with this change. The confusion between Ignite Apps and AppChain will be solved with better usage of the word App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:docs Documentation additions or improvements. type:internal type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

META: Reconsider "Apps" Naming
4 participants