-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename apps to extensions #4238
Conversation
Visit the preview URL for this PR (updated for commit deb9f16): https://igntservices-docs--pr4238-julien-extensions-pxr7efd9.web.app (expires Fri, 09 Aug 2024 14:18:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
I believe test is failing because error message still uses "app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
The only thing I saw in the code is that the integration test folder is still integration/plugin
. We can move to integration/extension
True, I'll fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignite/config/plugins/testdata/other/extensions.yml
content is also wrong
extensions:
- name: plugin1
path: /path/to/plugin1
- name: plugin2
path: /path/to/plugin2
with:
foo: bar
bar: baz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"can't attach app hook %q to non executable command %q"
error
0df3f1b
c6f6e6c
to
b5c5f1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still have some merge conflicts
We have discussed internally that we'll not proceed yet with this change. The confusion between Ignite Apps and AppChain will be solved with better usage of the word App. |
Closes: #4235