-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove protoc
pkg and also nodetime helpers ts-proto
and sta
(backport #4090)
#4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta` (#4090) * remove protoc * add changelog * run go mod tidy * remove unused proto folder handling * add ts-client tests * remove unused methods * use import includes instead manual * use buf dep instead buf mod * change buf mod update to comand to buf dep update * improve code readbility * bump buf.build * bump buf into the go.mod * bump protobuf pkgs for buf * check if the folder has proto before update buf dependencies --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 8e0937d) # Conflicts: # go.mod # go.sum # ignite/internal/plugin/testdata/execute_fail/go.mod # ignite/internal/plugin/testdata/execute_ok/go.mod # ignite/internal/tools/gen-config-doc/go.mod # ignite/internal/tools/gen-config-doc/go.sum # ignite/internal/tools/gen-mig-diffs/go.mod # ignite/internal/tools/gen-mig-diffs/go.sum # ignite/pkg/cosmosbuf/buf.go # ignite/pkg/cosmosgen/generate_go.go # ignite/pkg/cosmosgen/generate_openapi.go # ignite/pkg/cosmosgen/generate_typescript.go # ignite/pkg/nodetime/nodetime.go # ignite/pkg/nodetime/programs/sta/sta.go # ignite/pkg/nodetime/programs/ts-proto/tsproto.go # ignite/pkg/protoc/protoc.go # ignite/templates/app/files/go.mod.plush # ignite/templates/app/files/proto/buf.lock # integration/doctor/testdata/missing-tools.go.txt # integration/plugin/testdata/example-plugin/go.mod
mergify
bot
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
July 1, 2024 18:54
Cherry-pick of 8e0937d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
github-actions
bot
added
component:ci
CI/CD workflow and automated jobs.
component:templates
component:configs
type:internal
component:packages
labels
Jul 1, 2024
…/release/v28.x.y/pr-4090 # Conflicts: # go.mod # go.sum # ignite/pkg/cosmosbuf/buf.go # integration/doctor/testdata/missing-tools.go.txt
…/release/v28.x.y/pr-4090 # Conflicts: # go.mod # go.sum # ignite/pkg/cosmosgen/generate.go # ignite/pkg/cosmosgen/generate_openapi.go # ignite/templates/app/files/go.mod.plush # ignite/templates/app/files/proto/buf.lock
…/release/v28.x.y/pr-4090 # Conflicts: # go.sum # ignite/pkg/cosmosgen/generate_typescript.go # integration/plugin/testdata/example-plugin/go.mod
…/release/v28.x.y/pr-4090 # Conflicts: # ignite/pkg/nodetime/nodetime.go
julienrbrt
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK!
Pantani
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:ci
CI/CD workflow and automated jobs.
component:cmd
component:configs
component:packages
component:templates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stop using the
protoc
with the node plugins so we can remove the node time binary. This PR's makes all ts generation using thebuf generate command
.Changes
buf mode update
tobuf dep update
;protoc
andnodetime
;buf.lock
dependency digest;How to test
check the
ts-client
folder into the chainThis is an automatic backport of pull request #4090 done by Mergify.