Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable copyloopvar linter #4160

Merged
merged 21 commits into from
Jun 18, 2024
Merged

chore: enable copyloopvar linter #4160

merged 21 commits into from
Jun 18, 2024

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 19, 2024 •
edited
Loading

Please make sure to check the following for your PR:

  • This PR complies with the contributing guidelines.
  • Reviewed "Files changed" and left comments if necessary
  • Included relevant documentation changes.

Ignite CLI team only:

  • I have updated the Unreleased section in the changelog.md for my changes.
  • If the templates in ignite/templates/files have been changed, make
    sure that the change doesn't need to be reflected in the
    ignite/templates/files-* folders.

@faddat faddat requested review from salmad3 and toschdev as code owners May 19, 2024 18:58
@github-actions github-actions bot added the type:services Service-related issues. label May 19, 2024
@Pantani Pantani self-requested a review May 27, 2024 19:03
Pantani
Pantani previously approved these changes May 27, 2024
View reviewed changes
julienrbrt
julienrbrt requested changes May 29, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending https://github.com/ignite/cli/pull/4160/files#r1608268565

@Pantani Pantani self-requested a review June 13, 2024 13:22
@github-actions github-actions bot removed the type:services Service-related issues. label Jun 13, 2024
Pantani
Pantani previously approved these changes Jun 13, 2024
View reviewed changes
@Pantani Pantani requested a review from julienrbrt June 13, 2024 13:53
julienrbrt
julienrbrt previously approved these changes Jun 18, 2024
View reviewed changes
@julienrbrt julienrbrt enabled auto-merge (squash) June 18, 2024 15:00
@julienrbrt julienrbrt dismissed stale reviews from Pantani and themself via 901f8f0 June 18, 2024 15:35
@julienrbrt julienrbrt merged commit bebb6ac into ignite:main Jun 18, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@Pantani Pantani Pantani left review comments

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@faddat faddat

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages type:internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @Pantani @julienrbrt