fix(protoanalysis,templates): fail at duplicate fields #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi and
Pantani
as code owners
github-actions
bot
added
component:ci
julienrbrt
changed the title
julienrbrt
changed the title
Pantani
reviewed
May 13, 2024
jeronimoalbi
approved these changes
May 13, 2024
julienrbrt
added a commit
that referenced
this pull request
May 29, 2024
* fix(templates): fail at duplicate fields * update pr number * styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in #4118 (https://github.com/ignite/cli/actions/runs/9023607632/job/24795771972?pr=4118).
This must be merged before. This PR allows failing at scaffolding instead of failing at proto generation.