feat(templates): use collections for map and remove multi index support #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
julienrbrt
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi and
Pantani
as code owners
Pantani
reviewed
May 7, 2024
Co-authored-by: Danilo Pantani <[email protected]>
Pantani
approved these changes
May 8, 2024
| @@ -259,24 +258,31 @@ func parseTypeFields(opts addTypeOptions) (field.Fields, error) { | |||
| } | |||
|
|
|||
| // mapGenerator returns the template generator for a map. | |||
| func mapGenerator(replacer placeholder.Replacer, opts *typed.Options, indexes []string) (*genny.Generator, error) { | |||
| func mapGenerator(replacer placeholder.Replacer, opts *typed.Options, index string) (*genny.Generator, error) { | |||
| // Parse indexes with the associated type | |||
There was a problem hiding this comment.
Suggested change
| // Parse indexes with the associated type | |
| // Parse index with the associated type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4054
Follow-up of #3707