feat: merge the swagger files manually instead use nodetime swagger-combine
#4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
github-actions
bot
added
component:ci
Pantani
force-pushed
the
feat/remove-node-swagger-combine
branch
from
6d74214 to
7cfcd78
Compare
julienrbrt
reviewed
Apr 12, 2024
julienrbrt
reviewed
Apr 12, 2024
julienrbrt
approved these changes
Apr 18, 2024
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
…combine` (#4077) * merge the Swagger files manually instead use nodejs swagger-combine * add changelog * remove unused function vars * remove unused error handler --------- Co-authored-by: Pantani <Pantani>
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
…combine` (#4077) * merge the Swagger files manually instead use nodejs swagger-combine * add changelog * remove unused function vars * remove unused error handler --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 6de2f33) # Conflicts: # go.mod # go.sum # ignite/pkg/cosmosgen/generate_openapi.go # ignite/pkg/nodetime/programs/swagger-combine/swagger-combine.go
Pantani
added a commit
that referenced
this pull request
Jul 10, 2024
…combine` (backport #4077) (#4225) * feat: merge the swagger files manually instead use nodetime `swagger-combine` (#4077) * merge the Swagger files manually instead use nodejs swagger-combine * add changelog * remove unused function vars * remove unused error handler --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 6de2f33) # Conflicts: # go.mod # go.sum # ignite/pkg/cosmosgen/generate_openapi.go # ignite/pkg/nodetime/programs/swagger-combine/swagger-combine.go * resolve conflicts * fix doctor integration tests * fix doctor tests --------- Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the package swagger-combine to merge all swagger files into the code instead of using the NodeJs pkg
swagger-combineinside the nodetime binary.How to test