Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove the ignite relayer and tools commands with all ts-relayer logic #4076

Merged
merged 29 commits into from
May 5, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Apr 8, 2024

needs merge ignite/apps#82 first

@Pantani Pantani self-assigned this Apr 8, 2024
@Pantani Pantani changed the title feat: remove ts relayer feat: remove ts relayer commands Apr 8, 2024
@Pantani Pantani requested review from salmad3 and toschdev as code owners April 8, 2024 17:41
@julienrbrt julienrbrt changed the title feat: remove ts relayer commands feat!: remove ts relayer commands Apr 8, 2024
@julienrbrt
Copy link
Member

See here: ignite/apps#82 (comment)
I think we should create a no-op hidden app here with Hermes install instruction for better UX or do like network and install Hermes app directly.

julienrbrt
julienrbrt previously approved these changes Apr 17, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

julienrbrt
julienrbrt previously approved these changes Apr 18, 2024
changelog.md Outdated Show resolved Hide resolved
@Pantani Pantani enabled auto-merge (squash) April 22, 2024 10:49
@Pantani Pantani changed the title feat!: remove the ignite realyer and tools commands with all ts-realyer logic feat!: remove the ignite relayer and tools commands with all ts-realyer logic Apr 22, 2024
changelog.md Outdated Show resolved Hide resolved
@Pantani Pantani changed the title feat!: remove the ignite relayer and tools commands with all ts-realyer logic feat!: remove the ignite relayer and tools commands with all ts-relayer logic Apr 22, 2024
@Pantani Pantani merged commit 77b665f into main May 5, 2024
46 checks passed
@Pantani Pantani deleted the feat/remove-relayer branch May 5, 2024 22:08
julienrbrt pushed a commit that referenced this pull request May 29, 2024
…ealyer logic (#4076)

* remove ts relayer

* remove unused commands

* remove ts relayer

* fix hermes relayer cmd for integration tests

* add relayer command ad default

* remove unused function

* Update changelog.md

* bump default hermes plugin version

* bump relayer into the tests

* run go mod tidy

* rollback relayer command into the integration tests

---------

Co-authored-by: Pantani <Pantani>
@Pantani Pantani added the backport/v28.x.y Backport to v28.x.y label Jul 2, 2024
mergify bot pushed a commit that referenced this pull request Jul 2, 2024
…ealyer logic (#4076)

* remove ts relayer

* remove unused commands

* remove ts relayer

* fix hermes relayer cmd for integration tests

* add relayer command ad default

* remove unused function

* Update changelog.md

* bump default hermes plugin version

* bump relayer into the tests

* run go mod tidy

* rollback relayer command into the integration tests

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 77b665f)

# Conflicts:
#	go.mod
#	go.sum
#	ignite/cmd/relayer.go
#	ignite/cmd/relayer_configure.go
#	ignite/cmd/relayer_connect.go
#	ignite/cmd/tools.go
#	ignite/pkg/nodetime/programs/ts-relayer/tsrelayer.go
#	ignite/pkg/relayer/chain.go
#	ignite/pkg/relayer/config/config.go
#	ignite/pkg/relayer/relayer.go
@Pantani Pantani removed the backport/v28.x.y Backport to v28.x.y label Jul 4, 2024
Pantani added a commit that referenced this pull request Jul 15, 2024
…elayer logic (backport #4076) (#4226)

* feat!: remove the ignite `realyer` and `tools` commands with all ts-realyer logic (#4076)

* remove ts relayer

* remove unused commands

* remove ts relayer

* fix hermes relayer cmd for integration tests

* add relayer command ad default

* remove unused function

* Update changelog.md

* bump default hermes plugin version

* bump relayer into the tests

* run go mod tidy

* rollback relayer command into the integration tests

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 77b665f)

# Conflicts:
#	go.mod
#	go.sum
#	ignite/cmd/relayer.go
#	ignite/cmd/relayer_configure.go
#	ignite/cmd/relayer_connect.go
#	ignite/cmd/tools.go
#	ignite/pkg/nodetime/programs/ts-relayer/tsrelayer.go
#	ignite/pkg/relayer/chain.go
#	ignite/pkg/relayer/config/config.go
#	ignite/pkg/relayer/relayer.go

* fix merge conflicts

* fix changelog

* bump hermes version

* bump hermes to future version for don't break the default plugin path

* remove unused commands

* rollback integration/plugin/testdata/example-plugin/go.mod

* rollback ignite/internal/plugin/testdata

* rollback integration/plugin/testdata/example-plugin/go.mod

---------

Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants