-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove the ignite relayer
and tools
commands with all ts-relayer logic
#4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
April 8, 2024 12:18
github-actions
bot
added
component:ci
CI/CD workflow and automated jobs.
component:configs
component:cmd
component:packages
labels
Apr 8, 2024
julienrbrt
changed the title
feat: remove ts relayer commands
feat!: remove ts relayer commands
Apr 8, 2024
See here: ignite/apps#82 (comment) |
julienrbrt
previously approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!
julienrbrt
previously approved these changes
Apr 18, 2024
julienrbrt
reviewed
Apr 18, 2024
Pantani
changed the title
feat!: remove the ignite
feat!: remove the ignite Apr 22, 2024
realyer
and tools
commands with all ts-realyer logicrelayer
and tools
commands with all ts-realyer logic
Pantani
commented
Apr 22, 2024
Pantani
changed the title
feat!: remove the ignite
feat!: remove the ignite Apr 22, 2024
relayer
and tools
commands with all ts-realyer logicrelayer
and tools
commands with all ts-relayer logic
# Conflicts: # ignite/pkg/relayer/relayer.go
julienrbrt
approved these changes
May 5, 2024
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
…ealyer logic (#4076) * remove ts relayer * remove unused commands * remove ts relayer * fix hermes relayer cmd for integration tests * add relayer command ad default * remove unused function * Update changelog.md * bump default hermes plugin version * bump relayer into the tests * run go mod tidy * rollback relayer command into the integration tests --------- Co-authored-by: Pantani <Pantani>
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
…ealyer logic (#4076) * remove ts relayer * remove unused commands * remove ts relayer * fix hermes relayer cmd for integration tests * add relayer command ad default * remove unused function * Update changelog.md * bump default hermes plugin version * bump relayer into the tests * run go mod tidy * rollback relayer command into the integration tests --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 77b665f) # Conflicts: # go.mod # go.sum # ignite/cmd/relayer.go # ignite/cmd/relayer_configure.go # ignite/cmd/relayer_connect.go # ignite/cmd/tools.go # ignite/pkg/nodetime/programs/ts-relayer/tsrelayer.go # ignite/pkg/relayer/chain.go # ignite/pkg/relayer/config/config.go # ignite/pkg/relayer/relayer.go
Pantani
added a commit
that referenced
this pull request
Jul 15, 2024
…elayer logic (backport #4076) (#4226) * feat!: remove the ignite `realyer` and `tools` commands with all ts-realyer logic (#4076) * remove ts relayer * remove unused commands * remove ts relayer * fix hermes relayer cmd for integration tests * add relayer command ad default * remove unused function * Update changelog.md * bump default hermes plugin version * bump relayer into the tests * run go mod tidy * rollback relayer command into the integration tests --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 77b665f) # Conflicts: # go.mod # go.sum # ignite/cmd/relayer.go # ignite/cmd/relayer_configure.go # ignite/cmd/relayer_connect.go # ignite/cmd/tools.go # ignite/pkg/nodetime/programs/ts-relayer/tsrelayer.go # ignite/pkg/relayer/chain.go # ignite/pkg/relayer/config/config.go # ignite/pkg/relayer/relayer.go * fix merge conflicts * fix changelog * bump hermes version * bump hermes to future version for don't break the default plugin path * remove unused commands * rollback integration/plugin/testdata/example-plugin/go.mod * rollback ignite/internal/plugin/testdata * rollback integration/plugin/testdata/example-plugin/go.mod --------- Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs merge ignite/apps#82 first