Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add skip-proto flag to s chain command #4019

Merged
merged 3 commits into from
Mar 18, 2024
Merged

feat(cli): add skip-proto flag to s chain command #4019

merged 3 commits into from
Mar 18, 2024

Conversation

julienrbrt
Copy link
Member

Adds a --skip-proto flag to s chain to speed up scaffolding.
Advanced user can enjoy faster scaffolding time but still need to run ignite chain serve or ignite chain build afterwards.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 26.06%. Comparing base (1f59bea) to head (d85c906).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4019      +/-   ##
==========================================
- Coverage   26.07%   26.06%   -0.01%     
==========================================
  Files         304      304              
  Lines       25438    25440       +2     
==========================================
- Hits         6632     6630       -2     
- Misses      18230    18233       +3     
- Partials      576      577       +1     
Files Coverage Δ
ignite/services/scaffolder/configs.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/init.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/message.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/module.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/packet.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/params.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/query.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/type.go 38.18% <0.00%> (ø)
ignite/cmd/scaffold_chain.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/scaffolder.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Mar 14, 2024
@mergify mergify bot merged commit c05237b into main Mar 18, 2024
42 of 48 checks passed
@mergify mergify bot deleted the julien/fast branch March 18, 2024 09:17
mergify bot pushed a commit that referenced this pull request Mar 18, 2024
Adds a `--skip-proto` flag to `s chain` to speed up scaffolding.
Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards.

(cherry picked from commit c05237b)

# Conflicts:
#	ignite/cmd/scaffold_chain.go
#	ignite/services/scaffolder/configs.go
#	ignite/services/scaffolder/init.go
#	ignite/services/scaffolder/params.go
julienrbrt added a commit that referenced this pull request Mar 19, 2024
#4030)

* feat(cli): add `skip-proto` flag to `s chain` command (#4019)

Adds a `--skip-proto` flag to `s chain` to speed up scaffolding.
Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards.

(cherry picked from commit c05237b)

# Conflicts:
#	ignite/cmd/scaffold_chain.go
#	ignite/services/scaffolder/configs.go
#	ignite/services/scaffolder/init.go
#	ignite/services/scaffolder/params.go

* fix conflicts

---------

Co-authored-by: Julien Robert <[email protected]>
julienrbrt added a commit that referenced this pull request May 29, 2024
Adds a `--skip-proto` flag to `s chain` to speed up scaffolding.
Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:templates type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants