-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: init app client API chainer only when chain info is available #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
added
type:bug
Something isn't working
component:extensions
Related to Ignite Extensions.
labels
Feb 13, 2024
github-actions
bot
added
component:ci
CI/CD workflow and automated jobs.
component:configs
component:cmd
labels
Feb 13, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3963 +/- ##
==========================================
+ Coverage 24.78% 24.79% +0.01%
==========================================
Files 296 296
Lines 24896 24904 +8
==========================================
+ Hits 6170 6176 +6
- Misses 18160 18161 +1
- Partials 566 567 +1
|
jeronimoalbi
requested review from
ilgooz,
salmad3,
toschdev,
Pantani,
julienrbrt and
Ehsan-saradar
as code owners
February 13, 2024 17:58
Ehsan-saradar
approved these changes
Feb 14, 2024
julienrbrt
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
…3963) * fix: init app client API chainer only when chain info is available * chore: update changelog --------- Co-authored-by: Ehsan-saradar <[email protected]> (cherry picked from commit ee46153)
julienrbrt
pushed a commit
that referenced
this pull request
Feb 14, 2024
…3963) (#3966) * fix: init app client API chainer only when chain info is available * chore: update changelog --------- Co-authored-by: Ehsan-saradar <[email protected]> (cherry picked from commit ee46153) Co-authored-by: Jerónimo Albi <[email protected]>
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
…3963) * fix: init app client API chainer only when chain info is available * chore: update changelog --------- Co-authored-by: Ehsan-saradar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v28.x.y
Backport to v28.x.y
component:ci
CI/CD workflow and automated jobs.
component:cmd
component:configs
component:extensions
Related to Ignite Extensions.
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3961