Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init app client API chainer only when chain info is available #3963

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

jeronimoalbi
Copy link
Member

Fixes #3961

@jeronimoalbi jeronimoalbi added type:bug Something isn't working component:extensions Related to Ignite Extensions. labels Feb 13, 2024
@jeronimoalbi jeronimoalbi self-assigned this Feb 13, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd labels Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7695df6) 24.78% compared to head (f800e26) 24.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3963      +/-   ##
==========================================
+ Coverage   24.78%   24.79%   +0.01%     
==========================================
  Files         296      296              
  Lines       24896    24904       +8     
==========================================
+ Hits         6170     6176       +6     
- Misses      18160    18161       +1     
- Partials      566      567       +1     
Files Coverage Δ
ignite/cmd/plugin.go 29.35% <62.50%> (+0.67%) ⬆️

@jeronimoalbi jeronimoalbi marked this pull request as ready for review February 13, 2024 17:58
@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Feb 13, 2024
ignite/cmd/plugin.go Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@jeronimoalbi jeronimoalbi merged commit ee46153 into main Feb 14, 2024
44 of 46 checks passed
@jeronimoalbi jeronimoalbi deleted the fix/app-client-api-chainer branch February 14, 2024 10:36
mergify bot pushed a commit that referenced this pull request Feb 14, 2024
…3963)

* fix: init app client API chainer only when chain info is available

* chore: update changelog

---------

Co-authored-by: Ehsan-saradar <[email protected]>
(cherry picked from commit ee46153)
julienrbrt pushed a commit that referenced this pull request Feb 14, 2024
…3963) (#3966)

* fix: init app client API chainer only when chain info is available

* chore: update changelog

---------

Co-authored-by: Ehsan-saradar <[email protected]>
(cherry picked from commit ee46153)

Co-authored-by: Jerónimo Albi <[email protected]>
julienrbrt pushed a commit that referenced this pull request May 29, 2024
…3963)

* fix: init app client API chainer only when chain info is available

* chore: update changelog

---------

Co-authored-by: Ehsan-saradar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:extensions Related to Ignite Extensions. type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Ignite CLI Panics When Retrieving Chain Info Outside Chain Working Directory
3 participants