Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cosmover): delete notion of app version #3903

Merged
merged 4 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- [#3835](https://github.com/ignite/cli/pull/3835) Add `--minimal` flag to `scaffold chain` to scaffold a chain with the least amount of sdk modules

### Changes

- [#3903](https://github.com/ignite/cli/pull/3903) Do not specify a default build tag and deprecate notion of app version

## [`v28.1.1`](https://github.com/ignite/cli/releases/tag/v28.1.1)

### Fixes
Expand Down
3 changes: 1 addition & 2 deletions ignite/cmd/chain_build.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"github.com/ignite/cli/v28/ignite/pkg/chaincmd"
"github.com/ignite/cli/v28/ignite/pkg/cliui"
"github.com/ignite/cli/v28/ignite/pkg/cliui/colors"
"github.com/ignite/cli/v28/ignite/pkg/cosmosver"
"github.com/ignite/cli/v28/ignite/services/chain"
)

Expand Down Expand Up @@ -91,7 +90,7 @@ for your current environment.
c.Flags().AddFlagSet(flagSetDebug())
c.Flags().Bool(flagRelease, false, "build for a release")
c.Flags().StringSliceP(flagReleaseTargets, "t", []string{}, "release targets. Available only with --release flag")
c.Flags().StringSlice(flagBuildTags, []string{cosmosver.DefaultVersion().String()}, "parameters to build the chain binary")
c.Flags().StringSlice(flagBuildTags, []string{}, "parameters to build the chain binary")
c.Flags().String(flagReleasePrefix, "", "tarball prefix for each release target. Available only with --release flag")
c.Flags().StringP(flagOutput, "o", "", "binary output path")
c.Flags().BoolP("verbose", "v", false, "verbose output")
Expand Down
3 changes: 1 addition & 2 deletions ignite/cmd/chain_init.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"github.com/ignite/cli/v28/ignite/pkg/chaincmd"
"github.com/ignite/cli/v28/ignite/pkg/cliui"
"github.com/ignite/cli/v28/ignite/pkg/cliui/colors"
"github.com/ignite/cli/v28/ignite/pkg/cosmosver"
"github.com/ignite/cli/v28/ignite/services/chain"
)

Expand Down Expand Up @@ -89,7 +88,7 @@ commands manually to ensure a production-level node initialization.
c.Flags().AddFlagSet(flagSetCheckDependencies())
c.Flags().AddFlagSet(flagSetSkipProto())
c.Flags().AddFlagSet(flagSetDebug())
c.Flags().StringSlice(flagBuildTags, []string{cosmosver.DefaultVersion().String()}, "parameters to build the chain binary")
c.Flags().StringSlice(flagBuildTags, []string{}, "parameters to build the chain binary")

return c
}
Expand Down
3 changes: 1 addition & 2 deletions ignite/cmd/chain_serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"github.com/ignite/cli/v28/ignite/pkg/cliui"
uilog "github.com/ignite/cli/v28/ignite/pkg/cliui/log"
cliuimodel "github.com/ignite/cli/v28/ignite/pkg/cliui/model"
"github.com/ignite/cli/v28/ignite/pkg/cosmosver"
"github.com/ignite/cli/v28/ignite/pkg/errors"
"github.com/ignite/cli/v28/ignite/pkg/events"
"github.com/ignite/cli/v28/ignite/services/chain"
Expand Down Expand Up @@ -76,7 +75,7 @@ production, you may want to run "appd start" manually.
c.Flags().BoolP(flagResetOnce, "r", false, "reset the app state once on init")
c.Flags().Bool(flagGenerateClients, false, "generate code for the configured clients on reset or source code change")
c.Flags().Bool(flagQuitOnFail, false, "quit program if the app fails to start")
c.Flags().StringSlice(flagBuildTags, []string{cosmosver.DefaultVersion().String()}, "parameters to build the chain binary")
c.Flags().StringSlice(flagBuildTags, []string{}, "parameters to build the chain binary")

return c
}
Expand Down
8 changes: 4 additions & 4 deletions ignite/pkg/cosmosanalysis/app/app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ var (
NoAppFile []byte
//go:embed testdata/two_app.go
TwoAppFile []byte
//go:embed testdata/app_v2.go
AppV2 []byte
//go:embed testdata/app_di.go
julienrbrt marked this conversation as resolved.
Show resolved Hide resolved
AppDepinject []byte
)

func TestCheckKeeper(t *testing.T) {
Expand Down Expand Up @@ -55,8 +55,8 @@ func TestCheckKeeper(t *testing.T) {
expectedError: "app.go should contain a single app (got 2)",
},
{
name: "app v2",
appFile: AppV2,
name: "app depinject",
appFile: AppDepinject,
keeperName: "FooKeeper",
},
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build !app_v1
//go:build !hack-to-no-include-deps-in-ignite

package simapp

Expand Down
19 changes: 0 additions & 19 deletions ignite/pkg/cosmosver/app.go

This file was deleted.

Loading